BUG: fix HDFStore.append with all empty strings error (GH12242) #23435
Conversation
|
Hello @josham! Thanks for submitting the PR.
|
doc/source/whatsnew/v0.24.0.txt
Outdated
| @@ -1216,6 +1216,7 @@ Notice how we now instead output ``np.nan`` itself instead of a stringified form | |||
| - :func:`read_sas()` will correctly parse sas7bdat files with data page types having also bit 7 set (so page type is 128 + 256 = 384) (:issue:`16615`) | |||
| - Bug in :meth:`detect_client_encoding` where potential ``IOError`` goes unhandled when importing in a mod_wsgi process due to restricted access to stdout. (:issue:`21552`) | |||
| - Bug in :func:`to_string()` that broke column alignment when ``index=False`` and width of first column's values is greater than the width of first column's header (:issue:`16839`, :issue:`13032`) | |||
| - Bug in :meth:`HDFStore.append` when appending a :class:`DataFrame` with an empty string column and min_itemsize < 8 (:issue:`12242`) | |||
There was a problem hiding this comment.
Double backticks around min_itemsize
pandas/tests/io/test_pytables.py
Outdated
| store.append('df', df1, min_itemsize={'x': 1}) | ||
| store.append('df', df2, min_itemsize={'x': 1}) | ||
| tm.assert_frame_equal(store.select('df'), | ||
| pd.concat([df1, df2])) |
There was a problem hiding this comment.
Instead of comparing to pd.concat. Can you explicitly construct the DataFrame?
There was a problem hiding this comment.
can you push this to a new test, the existing ones are really long already
Codecov Report
@@ Coverage Diff @@
## master #23435 +/- ##
==========================================
- Coverage 92.21% 92.21% -0.01%
==========================================
Files 161 161
Lines 51189 51187 -2
==========================================
- Hits 47204 47202 -2
Misses 3985 3985
Continue to review full report at Codecov.
|
pandas/tests/io/test_pytables.py
Outdated
| store.append('df', df1, min_itemsize={'x': 1}) | ||
| store.append('df', df2, min_itemsize={'x': 1}) | ||
| tm.assert_frame_equal(store.select('df'), | ||
| pd.concat([df1, df2])) |
There was a problem hiding this comment.
can you push this to a new test, the existing ones are really long already
|
can you rebase again, the whatsnew is conflicted. ping on green. |
|
lgtm. ping on green. |
|
@jreback green |
|
thanks @josham |
git diff upstream/master -u -- "*.py" | flake8 --diff